Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11193 )
Change subject: IMPALA-7425: Change incremental stats to pull from catalogd. ...................................................................... Patch Set 13: Code-Review+2 (5 comments) Feel free to carry my +2 after fixing nits. http://gerrit.cloudera.org:8080/#/c/11193/12/fe/src/main/java/org/apache/impala/analysis/ComputeStatsStmt.java File fe/src/main/java/org/apache/impala/analysis/ComputeStatsStmt.java: http://gerrit.cloudera.org:8080/#/c/11193/12/fe/src/main/java/org/apache/impala/analysis/ComputeStatsStmt.java@639 PS12, Line 639: && !RuntimeEnv.INSTANCE.isTestEnv()); > added a todo to the caller before, so brought it down to this method to mak sry I missed that, here is fine too. thanks http://gerrit.cloudera.org:8080/#/c/11193/13/fe/src/main/java/org/apache/impala/analysis/ComputeStatsStmt.java File fe/src/main/java/org/apache/impala/analysis/ComputeStatsStmt.java: http://gerrit.cloudera.org:8080/#/c/11193/13/fe/src/main/java/org/apache/impala/analysis/ComputeStatsStmt.java@639 PS13, Line 639: && !RuntimeEnv.INSTANCE.isTestEnv() Oh, I see you are setting the gflag in the tests, so this probably not needed. Your call. http://gerrit.cloudera.org:8080/#/c/11193/12/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/11193/12/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@411 PS12, Line 411: le sry, just noticed this, formatting http://gerrit.cloudera.org:8080/#/c/11193/12/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@421 PS12, Line 421: table.getClass().getCanonicalName()); > The check on L409 is insufficient. A table can be Incomplete, but not yet l ok. http://gerrit.cloudera.org:8080/#/c/11193/13/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/11193/13/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@398 PS13, Line 398: && !RuntimeEnv.INSTANCE.isTestEnv() Same. -- To view, visit http://gerrit.cloudera.org:8080/11193 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9d564808ca5157afe4e091909ca6cdac76e60d6e Gerrit-Change-Number: 11193 Gerrit-PatchSet: 13 Gerrit-Owner: Vuk Ercegovac <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Wed, 05 Sep 2018 16:08:45 +0000 Gerrit-HasComments: Yes
