Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11193 )
Change subject: IMPALA-7425: Change incremental stats to pull from catalogd. ...................................................................... Patch Set 13: (3 comments) http://gerrit.cloudera.org:8080/#/c/11193/13/fe/src/main/java/org/apache/impala/analysis/ComputeStatsStmt.java File fe/src/main/java/org/apache/impala/analysis/ComputeStatsStmt.java: http://gerrit.cloudera.org:8080/#/c/11193/13/fe/src/main/java/org/apache/impala/analysis/ComputeStatsStmt.java@639 PS13, Line 639: && !RuntimeEnv.INSTANCE.isTestEnv() > Oh, I see you are setting the gflag in the tests, so this probably not need left it (and the other one) as-is. http://gerrit.cloudera.org:8080/#/c/11193/12/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/11193/12/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@411 PS12, Line 411: le > sry, just noticed this, formatting Done http://gerrit.cloudera.org:8080/#/c/11193/13/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/11193/13/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@398 PS13, Line 398: && !RuntimeEnv.INSTANCE.isTestEnv() > Same. left as-is. -- To view, visit http://gerrit.cloudera.org:8080/11193 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9d564808ca5157afe4e091909ca6cdac76e60d6e Gerrit-Change-Number: 11193 Gerrit-PatchSet: 13 Gerrit-Owner: Vuk Ercegovac <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Wed, 05 Sep 2018 16:16:54 +0000 Gerrit-HasComments: Yes
