Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/11396 )
Change subject: IMPALA-7542: find-fragment-instances misses to find the "root threads" ...................................................................... Patch Set 1: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/11396/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11396/1//COMMIT_MSG@7 PS1, Line 7: IMPALA-7542: find-fragment-instances misses to find the "root threads" nit: Please make the short description about what this change does, not what the bug was, e.g. "fix find-fragment-instances to find all root threads". http://gerrit.cloudera.org:8080/#/c/11396/1//COMMIT_MSG@19 PS1, Line 19: I tested it locally on a core file. I think it would be great to have a test for this script, both to show how to use it and because it's somewhat hard to test. We don't need to add one in this change though, but I'll file a subsequent jira. http://gerrit.cloudera.org:8080/#/c/11396/1/lib/python/impala_py_lib/gdb/impala-gdb.py File lib/python/impala_py_lib/gdb/impala-gdb.py: http://gerrit.cloudera.org:8080/#/c/11396/1/lib/python/impala_py_lib/gdb/impala-gdb.py@47 PS1, Line 47: v nit: Can you rename this variable to something more descriptive, maybe tdi? I can't think of what "v" means. -- To view, visit http://gerrit.cloudera.org:8080/11396 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I35ae1a6b384b002b343689469f02ceabd84af1b6 Gerrit-Change-Number: 11396 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Zoram Thanga <[email protected]> Gerrit-Comment-Date: Thu, 06 Sep 2018 16:03:04 +0000 Gerrit-HasComments: Yes
