Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11396 )
Change subject: IMPALA-7542: fix find-fragment-instances to find all "root threads" ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/11396/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11396/1//COMMIT_MSG@7 PS1, Line 7: IMPALA-7542: fix find-fragment-instances to find all "root threads" > nit: Please make the short description about what this change does, not wha Done http://gerrit.cloudera.org:8080/#/c/11396/1//COMMIT_MSG@19 PS1, Line 19: > I think it would be great to have a test for this script, both to show how I agree, thanks! http://gerrit.cloudera.org:8080/#/c/11396/1/lib/python/impala_py_lib/gdb/impala-gdb.py File lib/python/impala_py_lib/gdb/impala-gdb.py: http://gerrit.cloudera.org:8080/#/c/11396/1/lib/python/impala_py_lib/gdb/impala-gdb.py@47 PS1, Line 47: t > nit: Can you rename this variable to something more descriptive, maybe tdi? Done -- To view, visit http://gerrit.cloudera.org:8080/11396 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I35ae1a6b384b002b343689469f02ceabd84af1b6 Gerrit-Change-Number: 11396 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Zoram Thanga <[email protected]> Gerrit-Comment-Date: Fri, 07 Sep 2018 09:38:46 +0000 Gerrit-HasComments: Yes
