Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/10744 )
Change subject: IMPALA-1760: Implement shutdown command ...................................................................... Patch Set 18: (3 comments) Thanks for doing this. http://gerrit.cloudera.org:8080/#/c/10744/18/be/src/service/impala-server.h File be/src/service/impala-server.h: http://gerrit.cloudera.org:8080/#/c/10744/18/be/src/service/impala-server.h@108 PS18, Line 108: /// 2. The startup grace period starts, during which: Can this be based instead on a successful startup indicator/flag that gets set when the daemon is considered to be fully started up? http://gerrit.cloudera.org:8080/#/c/10744/18/be/src/service/impala-server.h@119 PS18, Line 119: /// executing). If it is quiesced then it cleanly shut downs by exiting the process. nit: ...cleanly shuts down... http://gerrit.cloudera.org:8080/#/c/10744/18/be/src/service/impala-server.cc File be/src/service/impala-server.cc: http://gerrit.cloudera.org:8080/#/c/10744/18/be/src/service/impala-server.cc@2408 PS18, Line 2408: if (set_grace) { nit: online? -- To view, visit http://gerrit.cloudera.org:8080/10744 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d5606ccfec84db4482c1e7f0f198103aad141a0 Gerrit-Change-Number: 10744 Gerrit-PatchSet: 18 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Pranay Singh Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Zoram Thanga <zo...@cloudera.com> Gerrit-Comment-Date: Mon, 10 Sep 2018 18:20:24 +0000 Gerrit-HasComments: Yes
