Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10744 )
Change subject: IMPALA-1760: Implement shutdown command ...................................................................... Patch Set 18: (19 comments) http://gerrit.cloudera.org:8080/#/c/10744/18/be/src/service/impala-server.cc File be/src/service/impala-server.cc: http://gerrit.cloudera.org:8080/#/c/10744/18/be/src/service/impala-server.cc@215 PS18, Line 215: DEFINE_int64(shutdown_grace_period_s, 120, "Shutdown startup grace period in seconds. When " line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/10744/18/common/thrift/ImpalaInternalService.thrift File common/thrift/ImpalaInternalService.thrift: http://gerrit.cloudera.org:8080/#/c/10744/18/common/thrift/ImpalaInternalService.thrift@857 PS18, Line 857: // Deadline for the shutdown. After this deadline expires (starting at the time when this line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/10744/18/tests/custom_cluster/test_restart_services.py File tests/custom_cluster/test_restart_services.py: http://gerrit.cloudera.org:8080/#/c/10744/18/tests/custom_cluster/test_restart_services.py@101 PS18, Line 101: = flake8: E225 missing whitespace around operator http://gerrit.cloudera.org:8080/#/c/10744/18/tests/custom_cluster/test_restart_services.py@102 PS18, Line 102: @ flake8: E301 expected 1 blank line, found 0 http://gerrit.cloudera.org:8080/#/c/10744/18/tests/custom_cluster/test_restart_services.py@126 PS18, Line 126: : flake8: E231 missing whitespace after ':' http://gerrit.cloudera.org:8080/#/c/10744/18/tests/custom_cluster/test_restart_services.py@144 PS18, Line 144: : flake8: E231 missing whitespace after ':' http://gerrit.cloudera.org:8080/#/c/10744/18/tests/custom_cluster/test_restart_services.py@159 PS18, Line 159: = flake8: E225 missing whitespace around operator http://gerrit.cloudera.org:8080/#/c/10744/18/tests/custom_cluster/test_restart_services.py@160 PS18, Line 160: = flake8: E225 missing whitespace around operator http://gerrit.cloudera.org:8080/#/c/10744/18/tests/custom_cluster/test_restart_services.py@161 PS18, Line 161: @ flake8: E301 expected 1 blank line, found 0 http://gerrit.cloudera.org:8080/#/c/10744/18/tests/custom_cluster/test_restart_services.py@188 PS18, Line 188: = flake8: E712 comparison to True should be 'if cond is True:' or 'if cond:' http://gerrit.cloudera.org:8080/#/c/10744/18/tests/custom_cluster/test_restart_services.py@252 PS18, Line 252: = flake8: E225 missing whitespace around operator http://gerrit.cloudera.org:8080/#/c/10744/18/tests/custom_cluster/test_restart_services.py@253 PS18, Line 253: = flake8: E225 missing whitespace around operator http://gerrit.cloudera.org:8080/#/c/10744/18/tests/custom_cluster/test_restart_services.py@254 PS18, Line 254: @ flake8: E301 expected 1 blank line, found 0 http://gerrit.cloudera.org:8080/#/c/10744/18/tests/custom_cluster/test_restart_services.py@260 PS18, Line 260: g flake8: E126 continuation line over-indented for hanging indent http://gerrit.cloudera.org:8080/#/c/10744/18/tests/custom_cluster/test_restart_services.py@262 PS18, Line 262: F flake8: E501 line too long (96 > 90 characters) http://gerrit.cloudera.org:8080/#/c/10744/18/tests/custom_cluster/test_restart_services.py@289 PS18, Line 289: flake8: E203 whitespace before ':' http://gerrit.cloudera.org:8080/#/c/10744/18/tests/custom_cluster/test_restart_services.py@290 PS18, Line 290: flake8: E203 whitespace before ':' http://gerrit.cloudera.org:8080/#/c/10744/18/tests/custom_cluster/test_restart_services.py@295 PS18, Line 295: d flake8: E306 expected 1 blank line before a nested definition, found 0 http://gerrit.cloudera.org:8080/#/c/10744/18/tests/custom_cluster/test_restart_services.py@345 PS18, Line 345: r flake8: F841 local variable 'result' is assigned to but never used -- To view, visit http://gerrit.cloudera.org:8080/10744 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d5606ccfec84db4482c1e7f0f198103aad141a0 Gerrit-Change-Number: 10744 Gerrit-PatchSet: 18 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Pranay Singh Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Zoram Thanga <[email protected]> Gerrit-Comment-Date: Mon, 10 Sep 2018 18:35:57 +0000 Gerrit-HasComments: Yes
