Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11376 )
Change subject: IMPALA-7519: Support elliptic curve ssl ciphers ...................................................................... Patch Set 2: (1 comment) Had a couple of questions about error handling. I don't feel super-confident about reviewing the usage of the OpenSSL API so it might help to get Dan Burkert or someone who knows OpenSSL a bit better to take a look. http://gerrit.cloudera.org:8080/#/c/11376/2/be/src/rpc/thrift-server.cc File be/src/rpc/thrift-server.cc: http://gerrit.cloudera.org:8080/#/c/11376/2/be/src/rpc/thrift-server.cc@380 PS2, Line 380: throw TSSLException("failed to configure ECDH support"); Can we include the OpenSSL errors for more context (for this and the other errors). Also, do we need to clear the OpenSSL error queue in that case? I know there's some weirdness with errors accumulating there. -- To view, visit http://gerrit.cloudera.org:8080/11376 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1666ceabec51b425e8a82be1cf519e2ac35fa5a6 Gerrit-Change-Number: 11376 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Marshall <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 11 Sep 2018 02:39:23 +0000 Gerrit-HasComments: Yes
