Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/11376 )
Change subject: IMPALA-7519: Support elliptic curve ssl ciphers ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/11376/1/be/src/rpc/thrift-server.cc File be/src/rpc/thrift-server.cc: http://gerrit.cloudera.org:8080/#/c/11376/1/be/src/rpc/thrift-server.cc@372 PS1, Line 372: c_unique_ptr<EC_KEY> ecdh{ > line too long (95 > 90) Done http://gerrit.cloudera.org:8080/#/c/11376/2/be/src/rpc/thrift-server.cc File be/src/rpc/thrift-server.cc: http://gerrit.cloudera.org:8080/#/c/11376/2/be/src/rpc/thrift-server.cc@380 PS2, Line 380: } > Can we include the OpenSSL errors for more context (for this and the other As far as I can tell from the openssl docs, none of the functions here populate the error queue (I didn't test this experimentally as I'm not sure how to trigger any of these calls to fail). Their return value will just be either 0 or 1 to indicate success of failure. http://gerrit.cloudera.org:8080/#/c/11376/1/tests/custom_cluster/test_client_ssl.py File tests/custom_cluster/test_client_ssl.py: http://gerrit.cloudera.org:8080/#/c/11376/1/tests/custom_cluster/test_client_ssl.py@114 PS1, Line 114: > flake8: E261 at least two spaces before inline comment Done -- To view, visit http://gerrit.cloudera.org:8080/11376 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1666ceabec51b425e8a82be1cf519e2ac35fa5a6 Gerrit-Change-Number: 11376 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Marshall <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Thomas Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Thu, 13 Sep 2018 20:05:42 +0000 Gerrit-HasComments: Yes
