Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/11459 )
Change subject: IMPALA-589: Add a sql function to return the impalad coordinator hostname for diagnostic purposes. ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Change looks good to me. It would be great to have the function take an optional query id argument so we can use it on a running query as well. But I realize that that's a lot of work, and the same info is discoverable from the CM. http://gerrit.cloudera.org:8080/#/c/11459/1/be/src/exprs/expr-test.cc File be/src/exprs/expr-test.cc: http://gerrit.cloudera.org:8080/#/c/11459/1/be/src/exprs/expr-test.cc@4961 PS1, Line 4961: ObjectPool pool; This does not seem to be used. -- To view, visit http://gerrit.cloudera.org:8080/11459 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I94d6e2664ba659b48df53c5c06f67b502c533e47 Gerrit-Change-Number: 11459 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Thomas Marshall <thomasmarsh...@cmu.edu> Gerrit-Reviewer: Zoram Thanga <zo...@cloudera.com> Gerrit-Comment-Date: Wed, 19 Sep 2018 23:06:04 +0000 Gerrit-HasComments: Yes
