Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/11459 )
Change subject: IMPALA-589: Add sql function returning the impalad coordinator hostname. ...................................................................... Patch Set 2: (1 comment) Can you also add an e2e test in testdata/workloads/functional-query/queries/QueryTest/exprs.text? http://gerrit.cloudera.org:8080/#/c/11459/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11459/2//COMMIT_MSG@7 PS2, Line 7: IMPALA-589: Add sql function returning the impalad coordinator hostname. I appreciate your thoroughness, but we generally make our commit messages a little more concise (esp. for such a small, straight-forward change). In particular, you can probably eliminate the "Implementation" section here, and you can definitely eliminate the "Limitations" section. -- To view, visit http://gerrit.cloudera.org:8080/11459 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I94d6e2664ba659b48df53c5c06f67b502c533e47 Gerrit-Change-Number: 11459 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Sherman <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Thomas Marshall <[email protected]> Gerrit-Reviewer: Zoram Thanga <[email protected]> Gerrit-Comment-Date: Thu, 20 Sep 2018 22:53:15 +0000 Gerrit-HasComments: Yes
