Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11468 )
Change subject: IMPALA-7596. Adding JvmPauseMonitor (and other GC) metrics to Impala metrics. ...................................................................... Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/11468/6/be/src/util/memory-metrics.cc File be/src/util/memory-metrics.cc: http://gerrit.cloudera.org:8080/#/c/11468/6/be/src/util/memory-metrics.cc@205 PS6, Line 205: [](const TGetJvmMemoryMetricsResponse& r) { return r.gc_num_info_threshold_exceeded; }); > line too long (94 > 90) Done http://gerrit.cloudera.org:8080/#/c/11468/6/be/src/util/memory-metrics.cc@207 PS6, Line 207: [](const TGetJvmMemoryMetricsResponse& r) { return r.gc_num_warn_threshold_exceeded; }); > line too long (94 > 90) Done http://gerrit.cloudera.org:8080/#/c/11468/6/be/src/util/memory-metrics.cc@212 PS6, Line 212: [](const TGetJvmMemoryMetricsResponse& r) { return r.gc_total_extra_sleep_time_millis; }); > line too long (96 > 90) Done -- To view, visit http://gerrit.cloudera.org:8080/11468 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia707393962ad94ef715ec015b3fe3bb1769104a2 Gerrit-Change-Number: 11468 Gerrit-PatchSet: 6 Gerrit-Owner: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 26 Sep 2018 18:41:23 +0000 Gerrit-HasComments: Yes
