Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11468 )
Change subject: IMPALA-7596. Adding JvmPauseMonitor (and other GC) metrics to Impala metrics. ...................................................................... Patch Set 8: Code-Review+2 (3 comments) http://gerrit.cloudera.org:8080/#/c/11468/8/be/src/util/memory-metrics.h File be/src/util/memory-metrics.h: http://gerrit.cloudera.org:8080/#/c/11468/8/be/src/util/memory-metrics.h@226 PS8, Line 226: // nit: /// (multiple places) http://gerrit.cloudera.org:8080/#/c/11468/8/be/src/util/memory-metrics.cc File be/src/util/memory-metrics.cc: http://gerrit.cloudera.org:8080/#/c/11468/8/be/src/util/memory-metrics.cc@246 PS8, Line 246: ok() Looks serious enough to log rather than silently returning. http://gerrit.cloudera.org:8080/#/c/11468/8/be/src/util/memory-metrics.cc@295 PS8, Line 295: for (const TJvmMemoryPool& usage: last_response_.memory_pools) { Can we DCHECK that last_response_ is not nullptr? Could happen if GrabMetrics...() fails in the first run. -- To view, visit http://gerrit.cloudera.org:8080/11468 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia707393962ad94ef715ec015b3fe3bb1769104a2 Gerrit-Change-Number: 11468 Gerrit-PatchSet: 8 Gerrit-Owner: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 26 Sep 2018 21:01:31 +0000 Gerrit-HasComments: Yes
