Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11521 )
Change subject: IMPALA-7595: Check the validity of the time part of Parquet timestamps ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/11521/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11521/3//COMMIT_MSG@30 PS3, Line 30: that separate error message is not necessary. Yeah, but the current error message is a bit misleading IMO, since currently it says something like "dates should be between 1400-01-01 and 9999-12-31". Or, maybe we can just change the error message to make it more general. http://gerrit.cloudera.org:8080/#/c/11521/3/be/src/exec/parquet-column-readers.cc File be/src/exec/parquet-column-readers.cc: http://gerrit.cloudera.org:8080/#/c/11521/3/be/src/exec/parquet-column-readers.cc@697 PS3, Line 697: !TimestampValue::IsValidDate(val->date()) : || !TimestampValue::IsValidTime(val->time()) Would it make sense to merge these two functions and have a single TimestampValue::IsValid() member function instead? http://gerrit.cloudera.org:8080/#/c/11521/3/be/src/runtime/timestamp-value.h File be/src/runtime/timestamp-value.h: http://gerrit.cloudera.org:8080/#/c/11521/3/be/src/runtime/timestamp-value.h@195 PS3, Line 195: then nit: than -- To view, visit http://gerrit.cloudera.org:8080/11521 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibc0ae651b6a0a028c61a15fd069ef9e904231058 Gerrit-Change-Number: 11521 Gerrit-PatchSet: 3 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 28 Sep 2018 09:52:42 +0000 Gerrit-HasComments: Yes
