Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11521 )
Change subject: IMPALA-7595: Check the validity of the time part of Parquet timestamps ...................................................................... Patch Set 5: Code-Review+2 (1 comment) Patch set 5 is just rebase + conflict resolution. http://gerrit.cloudera.org:8080/#/c/11521/4/common/thrift/generate_error_codes.py File common/thrift/generate_error_codes.py: http://gerrit.cloudera.org:8080/#/c/11521/4/common/thrift/generate_error_codes.py@370 PS4, Line 370: ("PARQUET_TIMESTAMP_INVALID_TIME_OF_DAY", 121, > Worth including the bogus value? Other value errors I checked do not include the value itself in the log, so I decided to do the same here. It may make sense to create a flag like ALLOW_VALUES_IN_LOGS and append the values to relevant log messages. -- To view, visit http://gerrit.cloudera.org:8080/11521 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibc0ae651b6a0a028c61a15fd069ef9e904231058 Gerrit-Change-Number: 11521 Gerrit-PatchSet: 5 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 01 Oct 2018 09:39:52 +0000 Gerrit-HasComments: Yes
