Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10950 )
Change subject: IMPALA-376: add built-in functions for parsing JSON ...................................................................... Patch Set 16: (6 comments) Thanks for your patience too. Adjusted the patch based on your comments. http://gerrit.cloudera.org:8080/#/c/10950/9/be/src/exprs/string-functions.cc File be/src/exprs/string-functions.cc: http://gerrit.cloudera.org:8080/#/c/10950/9/be/src/exprs/string-functions.cc@51 PS9, Line 51: static const bool kNeedFree = false; > That memory should be tracked indirectly - results_pool_ is a FreePool, whi Oh, yes. I thought it's the MemPool in udf.cc. Then I have no concerns :) http://gerrit.cloudera.org:8080/#/c/10950/15/be/src/exprs/string-functions.cc File be/src/exprs/string-functions.cc: http://gerrit.cloudera.org:8080/#/c/10950/15/be/src/exprs/string-functions.cc@72 PS15, Line 72: if (originalSize >= newSize) return originalPtr; > Put conditional on a single line. Done http://gerrit.cloudera.org:8080/#/c/10950/15/be/src/exprs/string-functions.cc@143 PS15, Line 143: } else { // multiple selected items, return an array string > Can't we use RETURN_NULL_IF_OOM in some of these places? Yes, missing these. Done http://gerrit.cloudera.org:8080/#/c/10950/15/be/src/exprs/string-functions.cc@267 PS15, Line 267: VERFLO > Nit: "Expected" Done http://gerrit.cloudera.org:8080/#/c/10950/15/be/src/exprs/string-functions.cc@336 PS15, Line 336: ctx->SetError(msg.c_str()); > line too long (102 > 90) Done http://gerrit.cloudera.org:8080/#/c/10950/15/be/src/exprs/string-functions.cc@389 PS15, Line 389: ++i; > Maybe put ++i on the next line? formatting looks weird. Done -- To view, visit http://gerrit.cloudera.org:8080/10950 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6a9d3598cb3beca0865a7edb094f3a5b602dbd2f Gerrit-Change-Number: 10950 Gerrit-PatchSet: 16 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Attila Jeges <[email protected]> Gerrit-Reviewer: Greg Rahn <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 28 Sep 2018 10:42:58 +0000 Gerrit-HasComments: Yes
