Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10950 )
Change subject: IMPALA-376: add built-in functions for parsing JSON ...................................................................... Patch Set 17: Looks like a clang-tidy failure: 12:13:38 /home/ubuntu/Impala/be/src/exprs/string-functions.cc:142:5: warning: unused exception parameter 'e' [clang-diagnostic-unused-exception-parameter] 12:13:38 /home/ubuntu/Impala/be/src/exprs/string-functions.cc:144:5: warning: unused exception parameter 'e' [clang-diagnostic-unused-exception-parameter] 12:13:38 /home/ubuntu/Impala/be/src/exprs/string-functions.cc:218:3: warning: unused exception parameter 'e' [clang-diagnostic-unused-exception-parameter] 12:13:38 /home/ubuntu/Impala/be/src/exprs/string-functions.cc:243:3: warning: unused exception parameter 'e' [clang-diagnostic-unused-exception-parameter] 12:13:38 /home/ubuntu/Impala/be/src/exprs/string-functions.cc:277:3: warning: unused exception parameter 'e' [clang-diagnostic-unused-exception-parameter] 12:13:38 /home/ubuntu/Impala/be/src/exprs/string-functions.cc:285:3: warning: unused exception parameter 'e' [clang-diagnostic-unused-exception-parameter] 12:13:38 /home/ubuntu/Impala/be/src/exprs/string-functions.cc:326:3: warning: unused exception parameter 'e' [clang-diagnostic-unused-exception-parameter] 12:13:38 /home/ubuntu/Impala/be/src/exprs/string-functions.cc:327:3: warning: unused exception parameter 'e' [clang-diagnostic-unused-exception-parameter] 12:13:38 /home/ubuntu/Impala/be/src/exprs/string-functions.cc:367:9: warning: unused exception parameter 'e' [clang-diagnostic-unused-exception-parameter] -- To view, visit http://gerrit.cloudera.org:8080/10950 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6a9d3598cb3beca0865a7edb094f3a5b602dbd2f Gerrit-Change-Number: 10950 Gerrit-PatchSet: 17 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Attila Jeges <[email protected]> Gerrit-Reviewer: Greg Rahn <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 28 Sep 2018 19:01:56 +0000 Gerrit-HasComments: No
