Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11539 )
Change subject: IMPALA-7599: make the number of local cache retries configurable ...................................................................... Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/11539/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11539/1//COMMIT_MSG@15 PS1, Line 15: Made several fixes to exception messages. > whats this? whoops, added to a wrong branch... thanks for catching it. when invalidate exception is thrown, the message was messed up due to {} instead of %s. the "name" of the object did not make sense either and was inconsistent with the other case where there this exception is thrown. the change is in CatalogMetaProvider. http://gerrit.cloudera.org:8080/#/c/11539/1/be/src/runtime/exec-env.cc File be/src/runtime/exec-env.cc: http://gerrit.cloudera.org:8080/#/c/11539/1/be/src/runtime/exec-env.cc@97 PS1, Line 97: local_catalog_max_fetch_r > Make it more clear, --local_catalog_max_metadata_fetch_retries / --local_ca added 'fetch'. metadata and catalog in the same name seems redundant. http://gerrit.cloudera.org:8080/#/c/11539/1/be/src/runtime/exec-env.cc@99 PS1, Line 99: frontend > Just to be sure, do we plan to skip these retries for non-fe paths? Like di clarified that its use is for accessing the local catalog's objects. http://gerrit.cloudera.org:8080/#/c/11539/1/tests/custom_cluster/test_local_catalog.py File tests/custom_cluster/test_local_catalog.py: http://gerrit.cloudera.org:8080/#/c/11539/1/tests/custom_cluster/test_local_catalog.py@220 PS1, Line 220: for c in [client1, client2]] > Maybe I'm missing something but we don't seem to be doing this? We set max_ tightened this to check that we never retry (since the retries are set to 0). http://gerrit.cloudera.org:8080/#/c/11539/1/tests/custom_cluster/test_local_catalog.py@251 PS1, Line 251: > else, do we need to re-throw and fail? the counter will be incorrect, so it'll fail. I'm not excluding other exceptions here. -- To view, visit http://gerrit.cloudera.org:8080/11539 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4f14d5a8728f3cb07c7710589c44c2cd52478ba8 Gerrit-Change-Number: 11539 Gerrit-PatchSet: 2 Gerrit-Owner: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Comment-Date: Fri, 28 Sep 2018 16:49:26 +0000 Gerrit-HasComments: Yes
