Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11539 )
Change subject: IMPALA-7599: make the number of local cache retries configurable ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/11539/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11539/3//COMMIT_MSG@16 PS3, Line 16: > May be mention that all other retries (outside of Frontend) will come in a Done. Note that most of these are from Frontend as well, but there are several cases outside as well. http://gerrit.cloudera.org:8080/#/c/11539/3/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/11539/3/fe/src/main/java/org/apache/impala/service/Frontend.java@1090 PS3, Line 1090: timeline.markEvent( : String.format("Retrying query planning due to inconsistent metadata " : + "fetch, attempt %s of %s: ", : attempt, INCONSISTENT_METADATA_NUM_RETRIES) > While we are here, can we move this out of the loop? messes up run-time pro avoided the repetition by printing a summary to the profile. note that it'll only be the last exception that's printed... conceivably, we may fail for a variety of reasons but I think its ok to get this level of detail from the logs. -- To view, visit http://gerrit.cloudera.org:8080/11539 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4f14d5a8728f3cb07c7710589c44c2cd52478ba8 Gerrit-Change-Number: 11539 Gerrit-PatchSet: 3 Gerrit-Owner: Vuk Ercegovac <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Fri, 28 Sep 2018 23:42:53 +0000 Gerrit-HasComments: Yes
