Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/11545 )
Change subject: IMPALA-5031: null ptr errors in C calls in BE tests ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/11545/1/be/src/udf/udf.cc File be/src/udf/udf.cc: http://gerrit.cloudera.org:8080/#/c/11545/1/be/src/udf/udf.cc@521 PS1, Line 521: std::copy(buf, buf + len, result.ptr); > I tried this out on godbolt and it results in two extra redundant compariso Here are some results from single_node_perf_run.py: Report Generated on 2018-10-02 Run Description: "ac33c0c42e1e7cc898893b1ae1f69c13287d20a8 vs 13e6428fecfbc16f0a8ad36c89126167e9988b5e" Cluster Name: UNKNOWN Lab Run Info: UNKNOWN Impala Version: impalad version 3.1.0-SNAPSHOT RELEASE () Baseline Impala Version: impalad version 3.1.0-SNAPSHOT RELEASE (2018-09-28) +----------+-----------------------+---------+------------+------------+----------------+ | Workload | File Format | Avg (s) | Delta(Avg) | GeoMean(s) | Delta(GeoMean) | +----------+-----------------------+---------+------------+------------+----------------+ | TPCH(40) | parquet / none / none | 8.24 | -0.67% | 5.50 | -0.74% | +----------+-----------------------+---------+------------+------------+----------------+ +----------+----------+-----------------------+--------+-------------+------------+-----------+----------------+-------+----------------+---------+--------+ | Workload | Query | File Format | Avg(s) | Base Avg(s) | Delta(Avg) | StdDev(%) | Base StdDev(%) | Iters | Median Diff(%) | MW Zval | Tval | +----------+----------+-----------------------+--------+-------------+------------+-----------+----------------+-------+----------------+---------+--------+ | TPCH(40) | TPCH-Q7 | parquet / none / none | 27.03 | 26.72 | +1.14% | 0.95% | 0.71% | 50 | +0.95% | 5.69 | 6.73 | | TPCH(40) | TPCH-Q11 | parquet / none / none | 1.35 | 1.33 | +1.16% | 2.90% | 3.70% | 50 | +0.34% | 1.55 | 1.74 | | TPCH(40) | TPCH-Q19 | parquet / none / none | 5.33 | 5.30 | +0.59% | 1.51% | 1.51% | 50 | +0.67% | 1.87 | 1.93 | | TPCH(40) | TPCH-Q2 | parquet / none / none | 2.03 | 2.02 | +0.32% | 3.59% | 4.83% | 50 | +0.05% | 0.57 | 0.37 | | TPCH(40) | TPCH-Q8 | parquet / none / none | 4.74 | 4.73 | +0.25% | 1.60% | 1.65% | 50 | +0.08% | 0.66 | 0.76 | | TPCH(40) | TPCH-Q18 | parquet / none / none | 16.10 | 16.09 | +0.11% | 2.05% | 1.56% | 50 | -0.03% | -0.41 | 0.29 | | TPCH(40) | TPCH-Q10 | parquet / none / none | 7.17 | 7.17 | +0.02% | 2.10% | 2.49% | 50 | +0.03% | 0.16 | 0.05 | | TPCH(40) | TPCH-Q20 | parquet / none / none | 2.87 | 2.87 | -0.00% | 3.09% | 2.96% | 50 | -0.03% | -0.16 | -0.01 | | TPCH(40) | TPCH-Q15 | parquet / none / none | 4.29 | 4.29 | -0.06% | 1.75% | 2.00% | 50 | -0.05% | -0.22 | -0.17 | | TPCH(40) | TPCH-Q21 | parquet / none / none | 34.25 | 34.30 | -0.14% | 0.63% | 0.87% | 50 | -0.09% | -0.56 | -0.89 | | TPCH(40) | TPCH-Q22 | parquet / none / none | 2.68 | 2.69 | -0.20% | 2.61% | 2.70% | 50 | -0.03% | -1.02 | -0.38 | | TPCH(40) | TPCH-Q16 | parquet / none / none | 2.82 | 2.83 | -0.26% | 1.85% | 1.58% | 50 | -0.05% | -1.89 | -0.76 | | TPCH(40) | TPCH-Q6 | parquet / none / none | 1.50 | 1.51 | -0.95% | 1.87% | 1.84% | 50 | -0.21% | -2.85 | -2.57 | | TPCH(40) | TPCH-Q12 | parquet / none / none | 3.29 | 3.33 | -1.16% | 2.61% | 3.14% | 50 | -1.37% | -1.61 | -2.01 | | TPCH(40) | TPCH-Q1 | parquet / none / none | 7.76 | 7.89 | -1.63% | 2.08% | 2.62% | 50 | -1.34% | -3.20 | -3.46 | | TPCH(40) | TPCH-Q14 | parquet / none / none | 3.23 | 3.29 | -1.93% | 1.32% | 2.85% | 50 | -1.55% | -4.29 | -4.37 | | TPCH(40) | TPCH-Q17 | parquet / none / none | 4.64 | 4.73 | -1.99% | 6.19% | 6.62% | 50 | -1.98% | -1.18 | -1.56 | | TPCH(40) | TPCH-Q9 | parquet / none / none | 19.02 | 19.45 | -2.18% | 0.75% | 0.60% | 50 | -2.32% | -8.14 | -16.35 | | TPCH(40) | TPCH-Q13 | parquet / none / none | 10.36 | 10.60 | -2.21% | 0.49% | 0.44% | 50 | -2.41% | -8.53 | -23.91 | | TPCH(40) | TPCH-Q5 | parquet / none / none | 11.03 | 10.98 | +0.44% | 8.47% | * 23.56% * | 50 | -6.82% | -4.65 | 0.12 | | TPCH(40) | TPCH-Q4 | parquet / none / none | 3.96 | 4.14 | -4.20% | 1.73% | 2.58% | 50 | -4.00% | -7.21 | -9.68 | | TPCH(40) | TPCH-Q3 | parquet / none / none | 5.90 | 6.32 | I -6.61% | 1.12% | 4.35% | 50 | I -5.96% | -8.26 | -10.45 | +----------+----------+-----------------------+--------+-------------+------------+-----------+----------------+-------+----------------+---------+--------+ (I) Improvement: TPCH(40) TPCH-Q3 [parquet / none / none] (6.32s -> 5.90s [-6.61%]) +--------------+------------+----------+----------+------------+-----------+----------+----------+------------+--------+---------+-----------+ | Operator | % of Query | Avg | Base Avg | Delta(Avg) | StdDev(%) | Max | Base Max | Delta(Max) | #Hosts | #Rows | Est #Rows | +--------------+------------+----------+----------+------------+-----------+----------+----------+------------+--------+---------+-----------+ | 05:AGGREGATE | 11.45% | 635.91ms | 631.23ms | +0.74% | 4.28% | 791.99ms | 771.99ms | +2.59% | 3 | 453.79K | 7.32M | | 03:HASH JOIN | 66.03% | 3.67s | 4.00s | -8.35% | 1.27% | 4.00s | 4.79s | -16.53% | 3 | 1.47M | 25.40M | | 07:EXCHANGE | 2.31% | 128.11ms | 127.29ms | +0.64% | 9.67% | 224.00ms | 220.00ms | +1.82% | 3 | 7.17M | 6.00M | | 01:SCAN HDFS | 13.30% | 738.68ms | 769.30ms | -3.98% | 4.35% | 863.99ms | 859.99ms | +0.47% | 3 | 7.17M | 6.00M | | 02:SCAN HDFS | 4.32% | 239.81ms | 263.40ms | -8.96% | 7.50% | 372.00ms | 375.99ms | -1.06% | 3 | 129.40M | 24.00M | +--------------+------------+----------+----------+------------+-----------+----------+----------+------------+--------+---------+-----------+ Significant perf change detected I didn't look into how to exercise this directly - I just assumed StringVal::CopyFrom is called frequently in common queries. -- To view, visit http://gerrit.cloudera.org:8080/11545 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I317ccc99549744a26d65f3e07242079faad0355a Gerrit-Change-Number: 11545 Gerrit-PatchSet: 1 Gerrit-Owner: Jim Apple <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 02 Oct 2018 13:36:31 +0000 Gerrit-HasComments: Yes
