Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11545 )
Change subject: IMPALA-5031: null ptr errors in C calls in BE tests ...................................................................... Patch Set 1: Code-Review+2 I think probably only in certain string operations, but not sure that it's really that much on the critical path. Seems ok... -- To view, visit http://gerrit.cloudera.org:8080/11545 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I317ccc99549744a26d65f3e07242079faad0355a Gerrit-Change-Number: 11545 Gerrit-PatchSet: 1 Gerrit-Owner: Jim Apple <jbapple-imp...@apache.org> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Tue, 02 Oct 2018 16:36:50 +0000 Gerrit-HasComments: No