Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/11564 )
Change subject: IMPALA-7648 part 1: add expected out-of-memory tests ...................................................................... Patch Set 2: Code-Review+1 (4 comments) http://gerrit.cloudera.org:8080/#/c/11564/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11564/2//COMMIT_MSG@10 PS2, Line 10: expected to fail with out-of-memory. maybe briefly list which cases/nodes from the JIRA this commit covers. http://gerrit.cloudera.org:8080/#/c/11564/2/testdata/workloads/functional-query/queries/QueryTest/exchange-mem-scaling.test File testdata/workloads/functional-query/queries/QueryTest/exchange-mem-scaling.test: http://gerrit.cloudera.org:8080/#/c/11564/2/testdata/workloads/functional-query/queries/QueryTest/exchange-mem-scaling.test@17 PS2, Line 17: Memory limit exceeded can add a more descriptive error string: "EXCHANGE_NODE (id=4) could not allocate 8.00 KB without exceeding limit." http://gerrit.cloudera.org:8080/#/c/11564/2/testdata/workloads/functional-query/queries/QueryTest/spilling-no-debug-action.test File testdata/workloads/functional-query/queries/QueryTest/spilling-no-debug-action.test: http://gerrit.cloudera.org:8080/#/c/11564/2/testdata/workloads/functional-query/queries/QueryTest/spilling-no-debug-action.test@77 PS2, Line 77: Memory limit exceeded you can add a more descriptive error like in the hash join one below. "Memory limit exceeded: Cannot perform aggregation at aggregator with id 1." http://gerrit.cloudera.org:8080/#/c/11564/2/tests/query_test/test_mem_usage_scaling.py File tests/query_test/test_mem_usage_scaling.py: http://gerrit.cloudera.org:8080/#/c/11564/2/tests/query_test/test_mem_usage_scaling.py@385 PS2, Line 385: """Test that HDFS scans can stay within a low memory limit. Before IMPALA-7096 they : were not aware of non-reserved memory consumption and could start up too many scanner : threads.""" nit: copy-paste error -- To view, visit http://gerrit.cloudera.org:8080/11564 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icd1a7eb97837b742a967c260cafb5a7f4f45412e Gerrit-Change-Number: 11564 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 03 Oct 2018 00:22:38 +0000 Gerrit-HasComments: Yes
