Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11564 )
Change subject: IMPALA-7648 part 1: add expected out-of-memory tests ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/11564/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11564/2//COMMIT_MSG@10 PS2, Line 10: expected to fail with out-of-memory: > maybe briefly list which cases/nodes from the JIRA this commit covers. Done http://gerrit.cloudera.org:8080/#/c/11564/2/testdata/workloads/functional-query/queries/QueryTest/exchange-mem-scaling.test File testdata/workloads/functional-query/queries/QueryTest/exchange-mem-scaling.test: http://gerrit.cloudera.org:8080/#/c/11564/2/testdata/workloads/functional-query/queries/QueryTest/exchange-mem-scaling.test@17 PS2, Line 17: Memory limit exceeded > can add a more descriptive error string: Unfortunately I don't think there's a way to write a totally deterministic test - there's a chance we'd hit memory limit exceeded from a different operator like the scan. http://gerrit.cloudera.org:8080/#/c/11564/2/testdata/workloads/functional-query/queries/QueryTest/exchange-mem-scaling.test@29 PS2, Line 29: order by l1.l_orderkey desc, l1.l_partkey, l1.l_suppkey, l1.l_linenumber > I need to add some more columns to the order by, it's not deterministic cur Done http://gerrit.cloudera.org:8080/#/c/11564/2/testdata/workloads/functional-query/queries/QueryTest/spilling-no-debug-action.test File testdata/workloads/functional-query/queries/QueryTest/spilling-no-debug-action.test: http://gerrit.cloudera.org:8080/#/c/11564/2/testdata/workloads/functional-query/queries/QueryTest/spilling-no-debug-action.test@77 PS2, Line 77: Memory limit exceeded > you can add a more descriptive error like in the hash join one below. Same concern as before - it's unlikely to be totally deterministic. The aggregation is the big memory consumer but it could still hit the memory limit somewhere else. -- To view, visit http://gerrit.cloudera.org:8080/11564 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icd1a7eb97837b742a967c260cafb5a7f4f45412e Gerrit-Change-Number: 11564 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Wed, 03 Oct 2018 01:27:56 +0000 Gerrit-HasComments: Yes
