Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11565 )
Change subject: Simplify expression to collect NULLs count ...................................................................... Patch Set 1: I can reproduce the difference you're seeing - the aggregation *is* dramatically slower. I think this isn't expected though, we should be compiling the first version to something efficient - I'd expect that to ultimately be more efficient if we get it right since it's only a single aggregate function. -- To view, visit http://gerrit.cloudera.org:8080/11565 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic68f8b4c3756eb1980ce299a602a7d56db1e507a Gerrit-Change-Number: 11565 Gerrit-PatchSet: 1 Gerrit-Owner: [email protected] Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Comment-Date: Thu, 04 Oct 2018 00:58:45 +0000 Gerrit-HasComments: No
