Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11565 )

Change subject: Simplify expression to collect NULLs count
......................................................................


Patch Set 2:

Your proposed version is faster than the current version, but that's because of 
a limitation in the if() function support: 
https://issues.apache.org/jira/browse/IMPALA-7655

If you rewrite with a case expression instead of if you get something thats 
much faster again.


--
To view, visit http://gerrit.cloudera.org:8080/11565
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic68f8b4c3756eb1980ce299a602a7d56db1e507a
Gerrit-Change-Number: 11565
Gerrit-PatchSet: 2
Gerrit-Owner: [email protected]
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Comment-Date: Thu, 04 Oct 2018 18:28:28 +0000
Gerrit-HasComments: No

Reply via email to