Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11157 )
Change subject: IMPALA-7349: Add Admission control support for automatically setting per host memory limit for a query ...................................................................... Patch Set 15: > "Cluster Memory Admitted" which tells us what value was used to admit the quer Ok, thanks. I think this is a good recent example for our continuing conversation about how to do "typing" on the profile strings. I think I wish that we had a Thrift structure for the query profile where we added this sort of thing rather than having a bunch of key/value pairs. It's got nothing to do with this change, though. Anyway, thanks for the info! (You're all clear as far as I'm concerned.) -- To view, visit http://gerrit.cloudera.org:8080/11157 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifec00141651982f5975803c2165b7d7a10ebeaa6 Gerrit-Change-Number: 11157 Gerrit-PatchSet: 15 Gerrit-Owner: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Thu, 04 Oct 2018 19:21:02 +0000 Gerrit-HasComments: No
