Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/11157 )
Change subject: IMPALA-7349: Add Admission control support for automatically setting per host memory limit for a query ...................................................................... Patch Set 15: (1 comment) http://gerrit.cloudera.org:8080/#/c/11157/15/testdata/workloads/functional-query/queries/QueryTest/admission-max-min-mem-limits.test File testdata/workloads/functional-query/queries/QueryTest/admission-max-min-mem-limits.test: http://gerrit.cloudera.org:8080/#/c/11157/15/testdata/workloads/functional-query/queries/QueryTest/admission-max-min-mem-limits.test@9 PS15, Line 9: set num_scanner_threads=8; > I think we should set this to 2 or 3, so that it works on smaller machines Yea I though that too, but the problem with 2-3 is that then the estimates is less than 32mb and that triggers the minReservation lower bound. I tried a couple of tables to get something more that that for a lower core count, but couldnt find anything. I wanted to keep the query simple enough so that the estimates dont change much with new changes to the planner. Lemme try to cook up a different query. -- To view, visit http://gerrit.cloudera.org:8080/11157 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifec00141651982f5975803c2165b7d7a10ebeaa6 Gerrit-Change-Number: 11157 Gerrit-PatchSet: 15 Gerrit-Owner: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Thu, 04 Oct 2018 19:34:12 +0000 Gerrit-HasComments: Yes
