Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/11604 )
Change subject: IMPALA-5031: fix signed overflows in decimal ...................................................................... Patch Set 1: Took a first pass on this. Functionally, it makes sense. Is there any performance impact? Does ArithmeticUtil::AsUnsigned() always get inlined? -- To view, visit http://gerrit.cloudera.org:8080/11604 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibf882428931e4f4264be2fc8cd9d6b1fc89b8ace Gerrit-Change-Number: 11604 Gerrit-PatchSet: 1 Gerrit-Owner: Jim Apple <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Comment-Date: Mon, 08 Oct 2018 22:09:00 +0000 Gerrit-HasComments: No
