Michal Ostrowski has posted comments on this change. ( http://gerrit.cloudera.org:8080/11604 )
Change subject: IMPALA-5031: fix signed overflows in decimal ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/11604/3/be/src/util/decimal-util.h File be/src/util/decimal-util.h: http://gerrit.cloudera.org:8080/#/c/11604/3/be/src/util/decimal-util.h@22 PS3, Line 22: #include <functional> Why is this required here? Shouldn't it be required by arithmetic-util.h and included there? -- To view, visit http://gerrit.cloudera.org:8080/11604 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibf882428931e4f4264be2fc8cd9d6b1fc89b8ace Gerrit-Change-Number: 11604 Gerrit-PatchSet: 3 Gerrit-Owner: Jim Apple <jbapple-imp...@apache.org> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michal Ostrowski <mostr...@cloudera.com> Gerrit-Comment-Date: Mon, 15 Oct 2018 16:02:19 +0000 Gerrit-HasComments: Yes
