Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/11630 )
Change subject: IMPALA-7681. Add Azure Blob File System (ADLS Gen2) support. ...................................................................... Patch Set 4: (2 comments) Add some comments on stuff found by running the tests: tests/query_test/test_resource_limits.py - Add SkipIfADLS/SkipIfABFS.hbase to test_resource_limits_hbase(). http://gerrit.cloudera.org:8080/#/c/11630/4/tests/custom_cluster/test_permanent_udfs.py File tests/custom_cluster/test_permanent_udfs.py: http://gerrit.cloudera.org:8080/#/c/11630/4/tests/custom_cluster/test_permanent_udfs.py@249 PS4, Line 249: @SkipIfIsilon.hive : @SkipIfS3.hive : @SkipIfLocal.hive Add SkipIfADLS.hive and SkipIfABFS.hive http://gerrit.cloudera.org:8080/#/c/11630/4/tests/util/abfs_util.py File tests/util/abfs_util.py: http://gerrit.cloudera.org:8080/#/c/11630/4/tests/util/abfs_util.py@36 PS4, Line 36: output = subprocess.output("hadoop fs -%s" % command) metadata/test_ddl.py:43: in test_drop_table_with_purge format(unique_database), file_data='t1') util/abfs_util.py:49: in create_file (status, output) = self.hadoop_fs_shell("put %s %s" % (tmp_path, path)) util/abfs_util.py:36: in hadoop_fs_shell output = subprocess.output("hadoop fs -%s" % command) E AttributeError: 'module' object has no attribute 'output' I think this should be subprocess.check_output() -- To view, visit http://gerrit.cloudera.org:8080/11630 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5120b071760e7655e78902dce8483f8f54de445d Gerrit-Change-Number: 11630 Gerrit-PatchSet: 4 Gerrit-Owner: mackror...@apache.org Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: mackror...@apache.org Gerrit-Comment-Date: Thu, 11 Oct 2018 16:28:01 +0000 Gerrit-HasComments: Yes
