Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/11630 )
Change subject: IMPALA-7681. Add Azure Blob File System (ADLS Gen2) support. ...................................................................... Patch Set 4: (4 comments) Looking through the existing skips, I don't think the combined ADLS skips vs ADLS+ABFS skips issue should impact this code change. That applies to more than just ADLS and can be tracked in a separate JIRA. I think this review is getting close. http://gerrit.cloudera.org:8080/#/c/11630/4/be/src/runtime/io/scan-range.cc File be/src/runtime/io/scan-range.cc: http://gerrit.cloudera.org:8080/#/c/11630/4/be/src/runtime/io/scan-range.cc@31 PS4, Line 31: Nit: remove stray line http://gerrit.cloudera.org:8080/#/c/11630/4/be/src/runtime/io/scan-range.cc@38 PS4, Line 38: // TODO: Decide if this should be done for ABFS Do we want to default to using this for ABFS as well? We'll need to do perf tests to check, but it seems reasonable to use what we are using for ADLS/S3 for ABFS until we know otherwise. http://gerrit.cloudera.org:8080/#/c/11630/4/tests/common/skip.py File tests/common/skip.py: http://gerrit.cloudera.org:8080/#/c/11630/4/tests/common/skip.py@63 PS4, Line 63: ADLS ADLS -> ABFS (same for other skips) http://gerrit.cloudera.org:8080/#/c/11630/4/tests/custom_cluster/test_permanent_udfs.py File tests/custom_cluster/test_permanent_udfs.py: http://gerrit.cloudera.org:8080/#/c/11630/4/tests/custom_cluster/test_permanent_udfs.py@310 PS4, Line 310: @SkipIfIsilon.hive : @SkipIfS3.hive : @SkipIfLocal.hive Same here -- To view, visit http://gerrit.cloudera.org:8080/11630 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5120b071760e7655e78902dce8483f8f54de445d Gerrit-Change-Number: 11630 Gerrit-PatchSet: 4 Gerrit-Owner: mackror...@apache.org Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: mackror...@apache.org Gerrit-Comment-Date: Thu, 11 Oct 2018 17:35:42 +0000 Gerrit-HasComments: Yes
