Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11638 )
Change subject: IMPALA-7669: Gracefully handle concurrent invalidate/partial fetch RPCs ...................................................................... IMPALA-7669: Gracefully handle concurrent invalidate/partial fetch RPCs The bug here was that any partial RPC on an IncompleteTable was throwing an NPE. Ideally, we attempt to load the table (if we find that it is not loaded) before making the partial info request, but a concurrent invalidate could reset the table state and move it back to an uninitialized state. This patch handles this case better by propagating a meaningful error to the caller. Testing: ------- - Added a test that fails consistently with an NPE without this patch. Change-Id: I8533f73f25ca42a20f146ddfd95d4213add9b705 Reviewed-on: http://gerrit.cloudera.org:8080/11638 Reviewed-by: Bharath Vissapragada <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M common/thrift/CatalogService.thrift M fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java M fe/src/main/java/org/apache/impala/catalog/IncompleteTable.java M fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java M fe/src/test/java/org/apache/impala/catalog/PartialCatalogInfoTest.java M tests/custom_cluster/test_local_catalog.py 6 files changed, 60 insertions(+), 3 deletions(-) Approvals: Bharath Vissapragada: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/11638 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I8533f73f25ca42a20f146ddfd95d4213add9b705 Gerrit-Change-Number: 11638 Gerrit-PatchSet: 5 Gerrit-Owner: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]>
