Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11638 )
Change subject: IMPALA-7669: Gracefully handle concurrent invalidate/partial fetch RPCs ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/11638/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11638/2//COMMIT_MSG@22 PS2, Line 22: tight loop in parallel shells worthwhile making an e2e test for this? we have a couple of these for query re-planning. http://gerrit.cloudera.org:8080/#/c/11638/2/fe/src/main/java/org/apache/impala/catalog/IncompleteTable.java File fe/src/main/java/org/apache/impala/catalog/IncompleteTable.java: http://gerrit.cloudera.org:8080/#/c/11638/2/fe/src/main/java/org/apache/impala/catalog/IncompleteTable.java@145 PS2, Line 145: cause_ == null This could be guarded equivalently at the call-site with isLoaded(). Here is an example where isLoaded can be either true or false. Default impl is that its always loaded but its unclear if all impls need to (or will need to) behave the same way. If partitions are fetched from a table that's not loaded, seems like a precondition violation. Not too strong an opinion here... putting it here makes all this easier to use and less error prone but at the risk of not uniformly handling the Table api more generally. http://gerrit.cloudera.org:8080/#/c/11638/2/fe/src/main/java/org/apache/impala/catalog/IncompleteTable.java@149 PS2, Line 149: more meaningful lookup status perhaps TABLE_NOT_LOADED? -- To view, visit http://gerrit.cloudera.org:8080/11638 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8533f73f25ca42a20f146ddfd95d4213add9b705 Gerrit-Change-Number: 11638 Gerrit-PatchSet: 2 Gerrit-Owner: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Comment-Date: Tue, 16 Oct 2018 07:24:31 +0000 Gerrit-HasComments: Yes
