Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11608 )
Change subject: IMPALA-7597: wraps retries around Frontend metadata operations. ...................................................................... Patch Set 5: Looks fine to me. Another way of doing it would be to take a more functional approach and add a method like RetryTracker#retry(Callable<T> callable), and pass the guts of the frontend methods in as callables there. That might be slightly more composable/reusable than repeating the while loop, and when we are wholesale in Java 8 it would be pretty concise using lambda syntax. The only downside might be in passing through exceptions, which don't really participate that well with callables/generics. I'm fine with this as is, though. -- To view, visit http://gerrit.cloudera.org:8080/11608 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I43a21571d54a7966c5c68bea1fe69dbc62be2a0b Gerrit-Change-Number: 11608 Gerrit-PatchSet: 5 Gerrit-Owner: Vuk Ercegovac <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Wed, 17 Oct 2018 19:38:12 +0000 Gerrit-HasComments: No
