Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11057 )
Change subject: IMPALA-5050: Add support to read TIMESTAMP_MILLIS and TIMESTAMP_MICROS from Parquet ...................................................................... Patch Set 16: (1 comment) http://gerrit.cloudera.org:8080/#/c/11057/16/be/src/exec/hdfs-parquet-scanner.cc File be/src/exec/hdfs-parquet-scanner.cc: http://gerrit.cloudera.org:8080/#/c/11057/16/be/src/exec/hdfs-parquet-scanner.cc@518 PS16, Line 518: (col_type.IsTimestampType()) { : stats_read = ColumnStatsReader::ReadTimestampStatFromThrift(col_chunk, col_order, : *node->element, ColumnStatsReader::StatsField::MIN, : CreateTimestampHelper(*node->element), static_cast<TimestampValue*>(slot)); : } else { : stats_read = ColumnStatsReader::ReadFromThrift( : col_chunk, col_type, col_order, ColumnStatsReader::StatsField::MIN, slot); : } For readability, I'd prefer this logic to be hidden in ReadFromThrift(). -- To view, visit http://gerrit.cloudera.org:8080/11057 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4c7c01fffa31b3d2ca3480adf6ff851137dadac3 Gerrit-Change-Number: 11057 Gerrit-PatchSet: 16 Gerrit-Owner: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Attila Jeges <atti...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Fri, 19 Oct 2018 13:43:52 +0000 Gerrit-HasComments: Yes
