Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11057 )
Change subject: IMPALA-5050: Add support to read TIMESTAMP_MILLIS and TIMESTAMP_MICROS from Parquet ...................................................................... Patch Set 18: (6 comments) http://gerrit.cloudera.org:8080/#/c/11057/18/be/src/exec/parquet-column-readers.cc File be/src/exec/parquet-column-readers.cc: http://gerrit.cloudera.org:8080/#/c/11057/18/be/src/exec/parquet-column-readers.cc@768 PS18, Line 768: if (UNLIKELY(!TimestampValue::IsValidDate(val->date()))) { A short comment hinting at why IsValidTime() is not needed might be useful for future readers - otherwise it looks asymmetrical with above. E.g // Time extracted from int64 unix timestamp is always in range therefore does not need to be validated. http://gerrit.cloudera.org:8080/#/c/11057/18/be/src/exec/parquet-common.h File be/src/exec/parquet-common.h: http://gerrit.cloudera.org:8080/#/c/11057/18/be/src/exec/parquet-common.h@433 PS18, Line 433: ParquetTimestampHelper The name is ok but a little vague. I wonder if ParquetTimestampDecoder would be clearer. http://gerrit.cloudera.org:8080/#/c/11057/18/be/src/exec/parquet-common.cc File be/src/exec/parquet-common.cc: http://gerrit.cloudera.org:8080/#/c/11057/18/be/src/exec/parquet-common.cc@114 PS18, Line 114: if (needs_conversion) { nit: can fit conditional on one line http://gerrit.cloudera.org:8080/#/c/11057/18/be/src/exec/parquet-common.cc@123 PS18, Line 123: v->UtcToLocal(*timezone_, &repeated_period_start); Ah, this is clever. http://gerrit.cloudera.org:8080/#/c/11057/18/be/src/util/dict-encoding.h File be/src/util/dict-encoding.h: http://gerrit.cloudera.org:8080/#/c/11057/18/be/src/util/dict-encoding.h@383 PS18, Line 383: inline nit: inline is already implied for functions in the class body http://gerrit.cloudera.org:8080/#/c/11057/18/be/src/util/dict-encoding.h@383 PS18, Line 383: ResetInner I feel like Decode() or DecodeHelper() would be clearer, since it describes what the function does. -- To view, visit http://gerrit.cloudera.org:8080/11057 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4c7c01fffa31b3d2ca3480adf6ff851137dadac3 Gerrit-Change-Number: 11057 Gerrit-PatchSet: 18 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Attila Jeges <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 01 Nov 2018 00:08:58 +0000 Gerrit-HasComments: Yes
