Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11669 )
Change subject: IMPALA-7545: Add queuing reason to query log ...................................................................... Patch Set 7: I don't love the approach of using profile strings as an interface between modules - it feels like this added a little bit of technical debt, but I appreciate that you added tests and shared the constant definitions so this should at least be maintainable. -- To view, visit http://gerrit.cloudera.org:8080/11669 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2e5d8de4f6691a9ba2594ca68c54ea4dca760545 Gerrit-Change-Number: 11669 Gerrit-PatchSet: 7 Gerrit-Owner: Pooja Nilangekar <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Pooja Nilangekar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Mon, 22 Oct 2018 15:23:16 +0000 Gerrit-HasComments: No
