Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11556 )
Change subject: IMPALA-6323 Allow constant analytic window expressions. ...................................................................... Patch Set 5: (3 comments) A few suggestions but otherwise LGTM. http://gerrit.cloudera.org:8080/#/c/11556/5/be/src/exec/analytic-eval-node.cc File be/src/exec/analytic-eval-node.cc: http://gerrit.cloudera.org:8080/#/c/11556/5/be/src/exec/analytic-eval-node.cc@397 PS5, Line 397: && !(order_by_eq_expr_eval_ == nullptr || I think we should try to remove this extra code path (multiple equivalent code paths is just harder to test). Maybe we can unset window_end in the constructor in this case so that the previous code path achieves the same thing (since a window + order_by_eq_expr_eval_ == NULL is equivalent to no window). http://gerrit.cloudera.org:8080/#/c/11556/5/fe/src/main/java/org/apache/impala/planner/AnalyticPlanner.java File fe/src/main/java/org/apache/impala/planner/AnalyticPlanner.java: http://gerrit.cloudera.org:8080/#/c/11556/5/fe/src/main/java/org/apache/impala/planner/AnalyticPlanner.java@308 PS5, Line 308: spurious newline http://gerrit.cloudera.org:8080/#/c/11556/5/testdata/workloads/functional-planner/queries/PlannerTest/analytic-fns.test File testdata/workloads/functional-planner/queries/PlannerTest/analytic-fns.test: http://gerrit.cloudera.org:8080/#/c/11556/5/testdata/workloads/functional-planner/queries/PlannerTest/analytic-fns.test@2473 PS5, Line 2473: Partition order/ordering -- To view, visit http://gerrit.cloudera.org:8080/11556 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idf129026c45120e9470df601268863634037908c Gerrit-Change-Number: 11556 Gerrit-PatchSet: 5 Gerrit-Owner: Michal Ostrowski <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Michal Ostrowski <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Mon, 22 Oct 2018 15:14:18 +0000 Gerrit-HasComments: Yes
