Philip Zeyliger has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11731 )

Change subject: IMPALA-7698: Add centos support to bootstrap_system.
......................................................................


Patch Set 4:

(6 comments)

Good news--the ORC / timestamp stuff is figured out.

Attila--this changes a line you and I talked about in 
https://gerrit.cloudera.org/#/c/11730/ back to readlink() from realpath(). 
Definitely a curiosity I would not have predicted!

I'm comfortable carrying the +2, but I'll let this linger for a bit to see if 
anyone wants to make more comments. I'm waiting on the review for the parent 
change, anyway.

Thanks Quanlong for hinting me to the conclusion of the timezone stuff. The 
update there is in the commit message.

http://gerrit.cloudera.org:8080/#/c/11731/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/11731/1//COMMIT_MSG@29
PS1, Line 29:
            : With Quanlong's help, I learned what was happening. 
test-with-docker was
            : translati
> The error is due to hive writes a wrong timezone name into the ORC files. I
Thank you!

You lead me on the right path. The updated commit message explains what 
happens, but basically the tz database for Java and Linux are different here, 
and Java is missing some entries.


http://gerrit.cloudera.org:8080/#/c/11731/2/bin/bootstrap_system.sh
File bin/bootstrap_system.sh:

http://gerrit.cloudera.org:8080/#/c/11731/2/bin/bootstrap_system.sh@145
PS2, Line 145:   
https://www-us.apache.org/dist/ant/binaries/apache-ant-1.9.13-bin.tar.gz
> line too long (93 > 90)
ignored.


http://gerrit.cloudera.org:8080/#/c/11731/2/bin/bootstrap_system.sh@147
PS2, Line 147: redhat sha512sum -c - <<< 
'c8321aa223f70d7e64d3d0274263000cfffb46fbea61488534e26f9f0245d99e9872d0888e35cd3274416392a13f80c748c07750caaeffa5f9cae1220020715f
  apache-ant-1.9.13-bin.tar.gz'
> line too long (187 > 90)
ignored


http://gerrit.cloudera.org:8080/#/c/11731/2/bin/bootstrap_system.sh@148
PS2, Line 148: redhat sudo tar -C /usr/local -xzf apache-maven-3.5.4-bin.tar.gz
> line too long (186 > 90)
ignored


http://gerrit.cloudera.org:8080/#/c/11731/2/bin/bootstrap_system.sh@196
PS2, Line 196: # widely.
> "localhost"
Done


http://gerrit.cloudera.org:8080/#/c/11731/3/bin/bootstrap_system.sh
File bin/bootstrap_system.sh:

http://gerrit.cloudera.org:8080/#/c/11731/3/bin/bootstrap_system.sh@139
PS3, Line 139: # Clean up yum caches
             : redhat sudo yum clean all
> Since you install EPEL above, you may want to install these packages for Ce
I removed this entirely. They don't seem to be strictly necessary at the moment.



--
To view, visit http://gerrit.cloudera.org:8080/11731
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id54294d7607f51de87a9de373dcfc4a33f4bedf5
Gerrit-Change-Number: 11731
Gerrit-PatchSet: 4
Gerrit-Owner: Philip Zeyliger <phi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org>
Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <laszlo.g...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com>
Gerrit-Comment-Date: Thu, 25 Oct 2018 03:39:53 +0000
Gerrit-HasComments: Yes

Reply via email to