Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11731 )
Change subject: IMPALA-7698: Add centos support to bootstrap_system. ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/11731/4/bin/bootstrap_system.sh File bin/bootstrap_system.sh: http://gerrit.cloudera.org:8080/#/c/11731/4/bin/bootstrap_system.sh@131 PS4, Line 131: pigz > Nit: pigz isn't listed under Ubuntu. Let's add it. I did the opposite; it doesn't exist in centos:6. Interestingly, yum doesn't fail if a package is missing. --setopt=skip_missing_names_on_install=False doesn't work on centos6. http://gerrit.cloudera.org:8080/#/c/11731/4/bin/bootstrap_system.sh@132 PS4, Line 132: sudo > Nit: sudo yum install sudo? Removed. -- To view, visit http://gerrit.cloudera.org:8080/11731 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id54294d7607f51de87a9de373dcfc4a33f4bedf5 Gerrit-Change-Number: 11731 Gerrit-PatchSet: 4 Gerrit-Owner: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Thu, 25 Oct 2018 16:28:16 +0000 Gerrit-HasComments: Yes
