Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11778 )
Change subject: IMPALA-7727: Fix TStatusCode to TErrorCode mapping ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/11778/2/be/src/common/status.cc File be/src/common/status.cc: http://gerrit.cloudera.org:8080/#/c/11778/2/be/src/common/status.cc@a172 PS2, Line 172: > You missed removing the declaration in the header. oops will do. http://gerrit.cloudera.org:8080/#/c/11778/2/testdata/workloads/functional-query/queries/QueryTest/compute-stats.test File testdata/workloads/functional-query/queries/QueryTest/compute-stats.test: http://gerrit.cloudera.org:8080/#/c/11778/2/testdata/workloads/functional-query/queries/QueryTest/compute-stats.test@2203 PS2, Line 2203: set mem_limit=10m; > Can you use a debug_action to force the error directly? That would be more Looks like we don't propagate debug actions to child queries? void ChildQuery::SetQueryOptions(const TQueryOptions& parent_options, TExecuteStatementReq* exec_stmt_req) { map<string, string> conf; #define QUERY_OPT_FN(NAME, ENUM, LEVEL)\ if (parent_options.__isset.NAME) {\ stringstream val;\ val << parent_options.NAME;\ conf[#ENUM] = val.str();\ } #define REMOVED_QUERY_OPT_FN(NAME, ENUM) QUERY_OPTS_TABLE #undef QUERY_OPT_FN #undef REMOVED_QUERY_OPT_FN // Ignore debug actions on child queries because they may cause deadlock. map<string, string>::iterator it = conf.find("DEBUG_ACTION"); if (it != conf.end()) conf.erase(it); exec_stmt_req->__set_confOverlay(conf); } -- To view, visit http://gerrit.cloudera.org:8080/11778 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie62527734aa73c1524c731773638590bdac9e789 Gerrit-Change-Number: 11778 Gerrit-PatchSet: 2 Gerrit-Owner: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Mon, 29 Oct 2018 18:42:36 +0000 Gerrit-HasComments: Yes
