Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11778 )
Change subject: IMPALA-7727: Fix TStatusCode to TErrorCode mapping ...................................................................... Patch Set 4: Code-Review+1 (2 comments) Thanks, Tim for the quick reviews. Carrying +1. http://gerrit.cloudera.org:8080/#/c/11778/3/be/src/util/error-util.cc File be/src/util/error-util.cc: http://gerrit.cloudera.org:8080/#/c/11778/3/be/src/util/error-util.cc@231 PS3, Line 231: DCHECK(false) << "Unexpected hs2Code: " << hs2Code; > clang-tidy failed because this didn't return a value. Fixed it. Missed in the previous rev. http://gerrit.cloudera.org:8080/#/c/11778/2/testdata/workloads/functional-query/queries/QueryTest/compute-stats.test File testdata/workloads/functional-query/queries/QueryTest/compute-stats.test: http://gerrit.cloudera.org:8080/#/c/11778/2/testdata/workloads/functional-query/queries/QueryTest/compute-stats.test@2203 PS2, Line 2203: set mem_limit=1m; > Ah interesting. Maybe consider setting a lower mem_limit just to be sure th Done -- To view, visit http://gerrit.cloudera.org:8080/11778 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie62527734aa73c1524c731773638590bdac9e789 Gerrit-Change-Number: 11778 Gerrit-PatchSet: 4 Gerrit-Owner: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Mon, 29 Oct 2018 23:48:01 +0000 Gerrit-HasComments: Yes
