Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11871 )
Change subject: IMPALA-6436: exit instead of abort for catalog startup failure ...................................................................... Patch Set 1: (1 comment) I only converted the one case that we knew to be problematic. The other cases looked like they should probably only fail if something was serious broken so maybe we'd want a core dump? I don't really know since I couldn't think of plausible scenarios where they'd fail. http://gerrit.cloudera.org:8080/#/c/11871/1/be/src/util/jni-util.h File be/src/util/jni-util.h: http://gerrit.cloudera.org:8080/#/c/11871/1/be/src/util/jni-util.h@89 PS1, Line 89: log the backtrace at FATAL level and abort the : // process > nit: I think LOG(FATAL) calls the abort. Maybe clarify that? I intended the comment to document the behaviour from the callers point of view, I think that's more of an implementation detail. -- To view, visit http://gerrit.cloudera.org:8080/11871 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4026dccb39843b847426112fc0fe9ba897e48dcc Gerrit-Change-Number: 11871 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Sat, 03 Nov 2018 00:37:59 +0000 Gerrit-HasComments: Yes
