Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11871 )
Change subject: IMPALA-6436: exit instead of abort for catalog startup failure ...................................................................... Patch Set 1: Code-Review+2 Thanks for tackling this. I think this is strictly better than what we had. At some point Dimitris suggested that we be more explicit about checking that the error actually is "Couldn't talk to HMS" rather than some other error, but, I think in practice it doesn't matter. I think we could also reasonably have just looped forever and kept trying to talk to HMS, but that's a different change, and this one is here now :) -- To view, visit http://gerrit.cloudera.org:8080/11871 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4026dccb39843b847426112fc0fe9ba897e48dcc Gerrit-Change-Number: 11871 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Sat, 03 Nov 2018 21:16:07 +0000 Gerrit-HasComments: No
