Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/11813 )
Change subject: IMPALA-5031: Jenkins jobs should fail when UBSAN fails ...................................................................... Patch Set 2: (2 comments) > (2 comments) > > The finalize.sh change looks great. I mentioned some concerns about > the killer process looking through a lot of logs every second. We > could maybe tighten it, or maybe it doesn't matter. Do you find the > tests run in a similar amount of time with and without the killer? Yes, they do run in a similar amount of time. http://gerrit.cloudera.org:8080/#/c/11813/1/bin/jenkins/all-tests.sh File bin/jenkins/all-tests.sh: http://gerrit.cloudera.org:8080/#/c/11813/1/bin/jenkins/all-tests.sh@45 PS1, Line 45: while ! grep -rI ": runtime error: " "${IMPALA_HOME}/logs" > There could be a log of logs here, no? We're actually only interested, I th There could, but I'm not 100% sure of all that we want to search. For instance, we appear to want to search the BE log be_tests/LastTest.log. Thank you for educating me about log_path. It appears that this has a couple of disadvantages. First, it separates the UBSAN logs from the BE test logs, which makes tracking down which test tickled which UBSAN error more difficult. Second, it writes to $LOG_PATH.$PID and doesn't clobber the old $LOG_PATH.$LAST_PID. This makes it hard to grep without accidentally grepping the earlier logs. Unfortunately, the no-recover option doesn't work with our suppressions. The dynamic suppressions don't work with no-recover, and the static ones don't work with distcc, since they have to be in a file and distcc doesn't know how to propagate that file. http://gerrit.cloudera.org:8080/#/c/11813/1/bin/jenkins/all-tests.sh@49 PS1, Line 49: >2 echo "Killing process $PID_TO_KILL because it invoked undefined behavior" > Could you add a logging echo before the kill? It may catch someone by surpr Done -- To view, visit http://gerrit.cloudera.org:8080/11813 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I783243458ac2765a97a1dd7dd40d458cc2e1d80b Gerrit-Change-Number: 11813 Gerrit-PatchSet: 2 Gerrit-Owner: Jim Apple <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Sat, 03 Nov 2018 22:01:16 +0000 Gerrit-HasComments: Yes
