Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11813 )
Change subject: IMPALA-5031: Jenkins jobs should fail when UBSAN fails ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/11813/1/bin/jenkins/all-tests.sh File bin/jenkins/all-tests.sh: http://gerrit.cloudera.org:8080/#/c/11813/1/bin/jenkins/all-tests.sh@45 PS1, Line 45: while ! grep -rI ": runtime error: " "${IMPALA_HOME}/logs" > There could, but I'm not 100% sure of all that we want to search. For insta Ok. If it's not slowing things down, no need to be clever. (We could also use find and mtime to find updated logs, but, again, no need to be clever.) http://gerrit.cloudera.org:8080/#/c/11813/1/bin/jenkins/all-tests.sh@53 PS1, Line 53: disown What kills the killer? i.e., I think it doesn't get killed based on experimenting with the script below. You could add an exit based on "test -e /proc/$PID_TO_KILL" inside of killer to let killer die if the parent process is gone. $cat t.sh function t { while true; do sleep 2 done } t & disown echo done -- To view, visit http://gerrit.cloudera.org:8080/11813 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I783243458ac2765a97a1dd7dd40d458cc2e1d80b Gerrit-Change-Number: 11813 Gerrit-PatchSet: 1 Gerrit-Owner: Jim Apple <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Mon, 05 Nov 2018 18:44:22 +0000 Gerrit-HasComments: Yes
