Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11057 )
Change subject: IMPALA-5050: Add support to read TIMESTAMP_MILLIS and TIMESTAMP_MICROS from Parquet ...................................................................... Patch Set 20: (1 comment) I have tried to minimize changes in patch set 20: - ColumnStatsReader's functions are no longer static - the members have the same name as parameters with an extra "_" - col_chunk.meta_data.type is replaced with element_.type simply because it is shorter - the two values must be the same http://gerrit.cloudera.org:8080/#/c/11057/16/be/src/exec/hdfs-parquet-scanner.cc File be/src/exec/hdfs-parquet-scanner.cc: http://gerrit.cloudera.org:8080/#/c/11057/16/be/src/exec/hdfs-parquet-scanner.cc@518 PS16, Line 518: string& fn_name = eval->root().function_name(); : ColumnStatsReader::StatsField stats_field; : if (fn_name == "lt" || fn_name == "le") { : // We need to get min stats. : stats_field = ColumnStatsReader::StatsField::MIN; : } else if (fn_name == "gt" || fn_name == "ge") { : // We need to get max stats. : s > I am still thinking about a way to make this nicer without major refactorin I have changed ColumnStatsReader to be a non-static class to reduce the number of arguments in its functions + hide the timestamp logic better. -- To view, visit http://gerrit.cloudera.org:8080/11057 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4c7c01fffa31b3d2ca3480adf6ff851137dadac3 Gerrit-Change-Number: 11057 Gerrit-PatchSet: 20 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Attila Jeges <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 05 Nov 2018 21:10:13 +0000 Gerrit-HasComments: Yes
