Tim Armstrong has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/11889 )
Change subject: IMPALA-7822: handle overflows in repeat() builtin ...................................................................... IMPALA-7822: handle overflows in repeat() builtin We need to carefully check that the intermediate value fits in an int64_t and the final size fits in an int. If they don't we raise an error and fail the query. Testing: Added a couple of backend tests to exercise the overflow check code paths. Change-Id: I872ce77bc2cb29116881c27ca2a5216f722cdb2a --- M be/src/exprs/expr-test.cc M be/src/exprs/string-functions-ir.cc M testdata/workloads/functional-query/queries/QueryTest/large_strings.test 3 files changed, 28 insertions(+), 5 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/89/11889/3 -- To view, visit http://gerrit.cloudera.org:8080/11889 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I872ce77bc2cb29116881c27ca2a5216f722cdb2a Gerrit-Change-Number: 11889 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Thomas Marshall <[email protected]>
