Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/11889 )
Change subject: IMPALA-7822: handle overflows in repeat() builtin ...................................................................... Patch Set 4: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/11889/4/testdata/workloads/functional-query/queries/QueryTest/large_strings.test File testdata/workloads/functional-query/queries/QueryTest/large_strings.test: http://gerrit.cloudera.org:8080/#/c/11889/4/testdata/workloads/functional-query/queries/QueryTest/large_strings.test@232 PS4, Line 232: repeat() result is larger than allowed limit of 1 GB character data The above test you modified already hits this path. Did you mean to have this hit the other path, i.e. "Number of repeats in repeat() call..."? -- To view, visit http://gerrit.cloudera.org:8080/11889 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I872ce77bc2cb29116881c27ca2a5216f722cdb2a Gerrit-Change-Number: 11889 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Thomas Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 07 Nov 2018 18:25:20 +0000 Gerrit-HasComments: Yes
