Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11893 )
Change subject: IMPALA-7823: Clean up Java warnings, fix minor issues ...................................................................... Patch Set 1: (3 comments) Few nits. LGTM overall. Thanks for the cleanup. http://gerrit.cloudera.org:8080/#/c/11893/1/fe/src/main/java/org/apache/impala/analysis/ColumnLineageGraph.java File fe/src/main/java/org/apache/impala/analysis/ColumnLineageGraph.java: http://gerrit.cloudera.org:8080/#/c/11893/1/fe/src/main/java/org/apache/impala/analysis/ColumnLineageGraph.java@86 PS1, Line 86: new LinkedHashMap<String, Object>(); (multiple places) We can also use Maps.newLinkedHashMap() for brevity or probably just the diamond operator new HashMap<>() http://gerrit.cloudera.org:8080/#/c/11893/1/fe/src/main/java/org/apache/impala/catalog/AuthorizationException.java File fe/src/main/java/org/apache/impala/catalog/AuthorizationException.java: http://gerrit.cloudera.org:8080/#/c/11893/1/fe/src/main/java/org/apache/impala/catalog/AuthorizationException.java@24 PS1, Line 24: @SuppressWarnings("serial") Apply this in the CatalogException class too and get rid of serialVersionUID..? http://gerrit.cloudera.org:8080/#/c/11893/1/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java File fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java: http://gerrit.cloudera.org:8080/#/c/11893/1/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java@96 PS1, Line 96: @SuppressWarnings("unused") Why can't we remove them? I'm not familiar enough with RuntimeFilter code. -- To view, visit http://gerrit.cloudera.org:8080/11893 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4b174d6448371c55e98487c6d4212c74c6b0c79e Gerrit-Change-Number: 11893 Gerrit-PatchSet: 1 Gerrit-Owner: Paul Rogers <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Paul Rogers <[email protected]> Gerrit-Comment-Date: Wed, 07 Nov 2018 20:35:05 +0000 Gerrit-HasComments: Yes
