Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11893 )
Change subject: IMPALA-7823: Clean up Java warnings, fix minor issues ...................................................................... Patch Set 1: (3 comments) Thanks Bharath for the review. Addressed comments. http://gerrit.cloudera.org:8080/#/c/11893/1/fe/src/main/java/org/apache/impala/analysis/ColumnLineageGraph.java File fe/src/main/java/org/apache/impala/analysis/ColumnLineageGraph.java: http://gerrit.cloudera.org:8080/#/c/11893/1/fe/src/main/java/org/apache/impala/analysis/ColumnLineageGraph.java@86 PS1, Line 86: new LinkedHashMap<String, Object>(); > (multiple places) We can also use Maps.newLinkedHashMap() for brevity or pr Not sure why this didn't work the first time. Now, Eclipse does allow the diamond form, so used that. The Guava methods were added prior to the diamond syntax; Google suggests using the more modern syntax instead. http://gerrit.cloudera.org:8080/#/c/11893/1/fe/src/main/java/org/apache/impala/catalog/AuthorizationException.java File fe/src/main/java/org/apache/impala/catalog/AuthorizationException.java: http://gerrit.cloudera.org:8080/#/c/11893/1/fe/src/main/java/org/apache/impala/catalog/AuthorizationException.java@24 PS1, Line 24: @SuppressWarnings("serial") > Apply this in the CatalogException class too and get rid of serialVersionU Done http://gerrit.cloudera.org:8080/#/c/11893/1/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java File fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java: http://gerrit.cloudera.org:8080/#/c/11893/1/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java@96 PS1, Line 96: @SuppressWarnings("unused") > Why can't we remove them? I'm not familiar enough with RuntimeFilter code. I'm not familiar with the code either or I would have removed them. I did remove a few others that clearly were not doing any good. -- To view, visit http://gerrit.cloudera.org:8080/11893 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4b174d6448371c55e98487c6d4212c74c6b0c79e Gerrit-Change-Number: 11893 Gerrit-PatchSet: 1 Gerrit-Owner: Paul Rogers <par0...@yahoo.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Paul Rogers <par0...@yahoo.com> Gerrit-Comment-Date: Wed, 07 Nov 2018 21:02:50 +0000 Gerrit-HasComments: Yes
